Comments on: A Cool / Unexpected Refactoring around .Net C# Locking Issue

By: candidiasis

candidiasis — Fri, 06 May 2011 09:27:04 +0000

Hi! Someone in my Myspace group shared this website with us so I came to take a look. I’m definitely loving the information. I’m book-marking and will be tweeting this to my followers! Fantastic blog and excellent design.

By: James Michael Hare

James Michael Hare — Mon, 23 Aug 2010 19:17:10 +0000

I like ReSharper a lot too. I’ve rarely found it’s refactorings to be off. If nothing else, it’s always good to have something making the suggestion so you can consider all angles!

By: Peter Kellner

Peter Kellner — Sun, 01 Aug 2010 16:18:08 +0000

Jelle,
I think you found a cut and paste error on my part. The “if” was not actually their when I did the refactor.

By: Jelle Hissink

Jelle Hissink — Sun, 01 Aug 2010 15:36:32 +0000

Did Resharper catch that you always assigned _dbProgressReportList? Otherwise it removed the “if (_dbProgressReportList == null)” where it should not have, the code will then behave differently after the refactoring.

By: James Curran

James Curran — Fri, 30 Jul 2010 19:07:16 +0000

Hmmm…. I would probably have written it as:

return new List(_dbProgrssReportList);

But I guess that’s probably better….